hudi-agent commented on code in PR #18878:
URL: https://github.com/apache/hudi/pull/18878#discussion_r3322148400
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -1099,6 +1099,9 @@ class HoodieSparkSqlWriterInternal {
}
}
val mergedParams = mutable.Map.empty ++
HoodieWriterUtils.parametersWithWriteDefaults(translatedOptsWithMappedTableConfig.toMap)
+ if (!mergedParams.contains(HoodieTableConfig.TYPE.key()) &&
mergedParams.contains(TABLE_TYPE.key())) {
+ mergedParams.put(HoodieTableConfig.TYPE.key(),
mergedParams(TABLE_TYPE.key()))
Review Comment:
🤖 nit: the immediately following block uses the idiomatic Scala
`mergedParams(key) = value` assignment syntax — could you use that here too
(`mergedParams(HoodieTableConfig.TYPE.key()) = mergedParams(TABLE_TYPE.key())`)
to stay consistent?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
