hudi-agent commented on code in PR #18837: URL: https://github.com/apache/hudi/pull/18837#discussion_r3323838526
########## hudi-trino-plugin/README.md: ########## @@ -0,0 +1,41 @@ +# hudi-trino-plugin + +Hudi connector for Trino (RFC-105). Published as `org.apache.hudi:hudi-trino` -- a regular non-shaded JAR. The Trino-side `trino-hudi` plugin module depends on this artifact and Trino's URLClassLoader isolates the plugin's transitive deps from the rest of the server, so no shading is required. + +The source directory is named `hudi-trino-plugin/`; the Maven artifactId is `hudi-trino`. + +## Build + +Excluded from default builds. Activate the `hudi-trino` Maven profile: + +``` +mvn -Phudi-trino -pl hudi-trino-plugin install -Dmaven.test.skip=true Review Comment: 🤖 Is it intentional that the documented quickstart now skips tests by default with `-Dmaven.test.skip=true`? Once this lands, new contributors following the README would build without running the plugin's tests — if there's a known test issue it might be worth a short comment in the README, otherwise dropping the flag would keep contributors on the green path. <sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
