hudi-agent commented on code in PR #18882:
URL: https://github.com/apache/hudi/pull/18882#discussion_r3324136640
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala:
##########
@@ -259,6 +255,34 @@ class HoodieMergeOnReadRDDV2(@transient sc: SparkContext,
}
}
+ private def withInputMetrics(iter: Iterator[InternalRow],
Review Comment:
🤖 nit: `closeableIter` implies the iterator is closeable, but its declared
type is `Iterator[InternalRow]` — closeability is only confirmed at runtime via
the match inside. Something like `underlyingIter` would convey its role (the
raw iterator to clean up) without setting an expectation the type signature
doesn't back up.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
