cshuo commented on code in PR #18793:
URL: https://github.com/apache/hudi/pull/18793#discussion_r3332145230


##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/utils/StreamWriteFunctionWrapper.java:
##########
@@ -369,7 +369,15 @@ public void jobFailover() throws Exception {
 
   public void coordinatorFails() throws Exception {
     this.coordinator.close();
-    resetCoordinatorToCheckpoint();
+    if (isStreamingWriteIndexEnabled) {
+      // RLI restore needs a synchronous executor before start() recreates the 
coordinator executor.
+      try (MockCoordinatorExecutor resetExecutor = new 
MockCoordinatorExecutor(coordinatorContext)) {
+        this.coordinator.setExecutor(resetExecutor);
+        resetCoordinatorToCheckpoint();

Review Comment:
   Here we're using try-wth-resources statement, `resetExecutor` will be auto 
closed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to