voonhous commented on code in PR #18837: URL: https://github.com/apache/hudi/pull/18837#discussion_r3340466408
########## hudi-trino-plugin/README.md: ########## @@ -0,0 +1,41 @@ +# hudi-trino-plugin + +Hudi connector for Trino (RFC-105). Published as `org.apache.hudi:hudi-trino` -- a regular non-shaded JAR. The Trino-side `trino-hudi` plugin module depends on this artifact and Trino's URLClassLoader isolates the plugin's transitive deps from the rest of the server, so no shading is required. + +The source directory is named `hudi-trino-plugin/`; the Maven artifactId is `hudi-trino`. + +## Build + +Excluded from default builds. Activate the `hudi-trino` Maven profile: + +``` +mvn -Phudi-trino -pl hudi-trino-plugin install -Dmaven.test.skip=true Review Comment: Intentional, and the flag is necessary: the plugin tests depend on Trino `*-tests.jar` artifacts that are not on Maven Central (built locally, gated behind the `hudi-trino-tests` profile which is off by default). Without that profile even test compilation fails, so `-Dmaven.test.skip=true` (skips compile + run, unlike `-DskipTests`) keeps the default `install` clean - dropping it would put contributors on a red path. Added a one-line inline comment in the build block in 3932c72 cross-referencing the Running tests section so the why is co-located. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
