fhan688 commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3347375131
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkWriteClients.java:
##########
@@ -242,10 +242,10 @@ public static HoodieWriteConfig getHoodieClientConfig(
.build())
.withIndexConfig(StreamerUtil.getIndexConfig(conf))
.withPayloadConfig(getPayloadConfig(conf))
+ .withProps(flinkConf2TypedProperties(conf))
Review Comment:
Good catch. The intended precedence change is only for
`hoodie.embed.timeline.server`, because Flink needs the coordinator/client
write-client creation path to decide whether the embedded timeline server is
started.
Moving `withProps(...)` before all three setters also changed precedence for
`hoodie.embed.timeline.server.reuse.enabled` and
`hoodie.allow.operation.metadata.field`, which is broader than intended. I
will narrow the change so only
`withEmbeddedTimelineServerEnabled(enableEmbeddedTimelineService)` is
applied after `withProps(...)`, while keeping the previous user-prop precedence
for reuse and operation metadata field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
