danny0405 commented on PR #18842: URL: https://github.com/apache/hudi/pull/18842#issuecomment-4618590238
> 🤖 _This review was generated by an AI agent and may contain mistakes. Please verify any suggestions before applying._ > > Thanks for the rename! The only new change in this round is the parameter rename in `KeyGenUtils.getRecordKeyFields(String)` from `recordKeyConfigValue` to `recordKeys`, which addresses @danny0405's prior comment. No new issues introduced. > > Status of prior findings: > > * Addressed: @danny0405's parameter rename request on `KeyGenUtils.java:335`. > * Still open: my nit on `OptionsResolver.java:183` (align `getBucketIndexKeys` with `getRecordKeys`), the `HoodieIndexConfig.java:782` normalization mismatch between record-key and hash fields, and the unrelated `TestTryWithResourcesExceptionHandling.java` test file that appears to have been accidentally included. > > Please take a look at the still-open prior comments, and this should be ready for a Hudi committer or PMC member to take it from here. are all these addressed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
