voonhous opened a new issue, #18935: URL: https://github.com/apache/hudi/issues/18935
### Background Spark 4.0 ships parquet 1.15.2, which does not have the variant `LogicalTypeAnnotation` (added in parquet 1.16.0+). Spark 4.1 ships parquet 1.16+. To keep variant writes working on both, `BaseSpark4Adapter.applyVariantLogicalType` is a no-op default and `Spark4_1Adapter` overrides it to actually apply `variantType()`. There is also a Spark 4.0-only read-support shim (`Spark40HoodieParquetReadSupport`) kept for the same reason. ### Cleanup to do once Spark 4.0 support is dropped When all remaining 4.x adapters are on parquet 1.16+: - Apply `variantType()` directly in `BaseSpark4Adapter.applyVariantLogicalType` and delete the no-op default plus the `Spark4_1Adapter` override. See `BaseSpark4Adapter.scala`. - Remove the `hudi-spark4.0.x` module shims, e.g. `Spark40HoodieParquetReadSupport` (`Spark40HoodieParquetReadSupport.scala`). ### Related - PR #18065 (introduced the no-op default / override split for variant shredding) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
