danny0405 commented on PR #18061:
URL: https://github.com/apache/hudi/pull/18061#issuecomment-4654640257

   > hey @yihua @danny0405 : this patch is adding more restriction to the 
ingestion. if precombine field is null, ingestion will fail due w/ right 
exception for table having non COMMIT_TIME based merge mode.
   > 
   > I feel, this might fail lot of workloads. we should just add it behind a 
flag if someone prefers to enable such strong expectations
   
   the preCombine field does not have default value not, it would anyway throws 
error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to