ashokkumar-allu commented on PR #18585: URL: https://github.com/apache/hudi/pull/18585#issuecomment-4664086813
Thanks for the review! Added the requested tests in this commit: **`TestHoodieLocalEngineContext`** (T1–T5): - `testMapParallelHappyPath` — verifies pool boots and returns correct results - `testMapParallelPropagatesRuntimeException` — verifies original exception is preserved as cause through the HoodieException wrapper - `testMapParallelPropagatesHoodieException` — verifies HoodieException cause is also preserved - `testMapParallelInterrupt` — verifies interrupt flag is restored and cause is `InterruptedException` - `testWorkerThreadClassloader` — regression guard that worker thread uses `HoodieLocalEngineContext.class.getClassLoader()` (the key fix) **`TestSparkPreCommitValidator`** (T6–T7, new file): - `testValidateWrapsNonValidationException` — RuntimeException from subclass is wrapped in `HoodieValidationException` - `testValidateReThrowsValidationException` — `HoodieValidationException` from subclass is rethrown as-is without extra wrapping **`TestSparkValidatorUtils`** (T8): - `testTwoValidatorsBothInvoked` — configures two `CountingValidator` instances, runs a real Spark write, and asserts both validators were invoked via `mapParallel` — the end-to-end integration test for the classloader-aware pool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
