yihua opened a new pull request, #18954:
URL: https://github.com/apache/hudi/pull/18954

   ### Describe the issue this Pull Request addresses
   
   The doc for `hoodie.datasource.read.begin.instanttime` (config alias 
`START_COMMIT`) currently states `New data written with completion_time >= 
START_COMMIT are fetched out`, with the example phrased `on or after`. This is 
inconsistent with the actual implementation, which treats `START_COMMIT` as 
**exclusive**:
   
   - V1 relation: timeline is filtered via `findInstantsInRange(start, end)` 
which is `(start, end]` (start-exclusive). See `InstantComparison.isInRange`.
   - V2 relation: defaults to `RangeType.OPEN_CLOSED` (start-exclusive) after 
`31166ce6f1 fix(query): Change start commit time to be exclusive in incremental 
query on Spark`.
   
   ### Summary and Changelog
   
   Updates the `START_COMMIT` config description to use `>` instead of `>=`, 
and rephrases the example from `on or after` to `strictly after`, matching the 
runtime behavior of both V1 and V2 incremental relations.
   
   ### Impact
   
   Documentation only. No code behavior change.
   
   ### Risk Level
   
   none
   
   ### Documentation Update
   
   This PR is the documentation update. A companion PR will update the 
published configuration pages on the Hudi docs site.
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [x] Adequate tests were added if applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to