nsivabalan commented on a change in pull request #2619:
URL: https://github.com/apache/hudi/pull/2619#discussion_r590423544
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/AvroKafkaSource.java
##########
@@ -42,18 +43,31 @@
*/
public class AvroKafkaSource extends AvroSource {
+ private static final String KAFKA_AVRO_VALUE_DESERIALIZER =
"hoodie.deltastreamer.source.kafka.value.deserializer.class";
private static final Logger LOG =
LogManager.getLogger(AvroKafkaSource.class);
-
private final KafkaOffsetGen offsetGen;
-
private final HoodieDeltaStreamerMetrics metrics;
public AvroKafkaSource(TypedProperties props, JavaSparkContext sparkContext,
SparkSession sparkSession,
SchemaProvider schemaProvider, HoodieDeltaStreamerMetrics metrics) {
super(props, sparkContext, sparkSession, schemaProvider);
- this.metrics = metrics;
+
props.put("key.deserializer", StringDeserializer.class);
- props.put("value.deserializer", KafkaAvroDeserializer.class);
+ String deserializerClassName =
props.getString(KAFKA_AVRO_VALUE_DESERIALIZER, "");
Review comment:
may be we should add default value to this config similar to others
configs in HoodieWriteClientConfig. I mean, where ever we move this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
