danny0405 commented on code in PR #18936:
URL: https://github.com/apache/hudi/pull/18936#discussion_r3392778097
##########
hudi-common/src/main/java/org/apache/hudi/common/util/HFileUtils.java:
##########
@@ -229,18 +240,43 @@ public ByteArrayOutputStream
serializeRecordsToLogBlock(HoodieStorage storage,
} catch (IOException e) {
throw new HoodieIOException("IOException serializing records", e);
}
+ if (enableBloomFilter) {
+ bloomFilter.add(recordKey);
+ if (minRecordKey == null) {
+ minRecordKey = recordKey;
Review Comment:
is it because the keys are asending order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
