ashokkumar-allu commented on code in PR #18585:
URL: https://github.com/apache/hudi/pull/18585#discussion_r3398617771
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/validator/SparkPreCommitValidator.java:
##########
@@ -82,6 +82,12 @@ public void validate(String instantTime,
HoodieWriteMetadata<O> writeResult, Dat
HoodieTimer timer = HoodieTimer.start();
try {
validateRecordsBeforeAndAfter(before, after,
getPartitionsModified(writeResult));
+ } catch (Exception e) {
Review Comment:
Good call — already using two catch blocks as suggested: `catch
(HoodieValidationException e) { throw e; }` followed by `catch (Exception e) {
... }`. No `instanceof` check in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
