wombatu-kun commented on code in PR #18957:
URL: https://github.com/apache/hudi/pull/18957#discussion_r3407422246
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ActiveTimelineV1.java:
##########
@@ -62,6 +62,8 @@
import static
org.apache.hudi.common.table.timeline.TimelineUtils.getHoodieInstantWriterOption;
+@NoArgsConstructor
Review Comment:
The hand-written no-arg constructor was `@Deprecated` ("for serialization
and de-serialization only"); `@NoArgsConstructor` regenerates it as a plain
public constructor, dropping that marker so callers no longer get the
deprecation warning. Same drop in `ActiveTimelineV2`. It is also inconsistent
with the still-`@Deprecated` `readObject` just below (line 109). If the
deprecation was intentional, keep the explicit constructor or use
`@NoArgsConstructor(onConstructor_ = @Deprecated)` to preserve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
