voonhous commented on code in PR #18965:
URL: https://github.com/apache/hudi/pull/18965#discussion_r3407556786
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -672,8 +697,8 @@ public static HoodieRecord<HoodieMetadataPayload>
createRecordIndexUpdate(String
fileIndex = Integer.parseInt(fileId.substring(index + 1));
}
} catch (Exception e) {
- throw new HoodieMetadataException(String.format("Invalid UUID or
index: fileID=%s, partition=%s, instantTime=%s",
- fileId, partition, instantTime), e);
+ throw new HoodieMetadataException(String.format("Invalid UUID or
index: fileID=%s, partition=%s, instantTimeMillis=%d",
Review Comment:
Good point on the long not being user-facing. Kept it off the hot path: the
per-record overload still stores the pre-parsed `instantTimeMillis`, and I only
reconstruct the human-readable instant time in the cold catch block via
`TimelineUtils.formatDate(new Date(instantTimeMillis))` (the exact inverse of
`parseDateFromInstantTime` -- both use the system default zone and the same
millis formatter). So the error message reads `instantTime=<...>` again, with
zero per-record cost since it only runs when a fileId actually fails to parse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
