wombatu-kun commented on code in PR #18988:
URL: https://github.com/apache/hudi/pull/18988#discussion_r3408307517
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -424,6 +424,8 @@ protected void completeCompaction(HoodieCommitMetadata
metadata, HoodieTable tab
);
}
log.info("Compacted successfully on commit {}", compactionCommitTime);
+ fireCommitCallbackIfNecessary(compactionCommitTime,
HoodieTimeline.COMMIT_ACTION,
Review Comment:
completeLogCompaction (LOG_COMPACTION_ACTION) is also a table-service
completion with write stats and a timeline commit, but it does not call
fireCommitCallbackIfNecessary while compaction and clustering do. Intentional
scope, or should log compaction fire the callback too? If intentional, a short
note here on why it is excluded would keep the set explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
