hudi-agent commented on code in PR #18957:
URL: https://github.com/apache/hudi/pull/18957#discussion_r3408524044
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineDiffHelper.java:
##########
@@ -125,48 +127,18 @@ private static List<Pair<HoodieInstant, HoodieInstant>>
getPendingActionTransiti
/**
* A diff result of timeline.
*/
+ @AllArgsConstructor
+ @Getter
+ @ToString
public static class TimelineDiffResult {
private final List<HoodieInstant> newlySeenInstants;
private final List<HoodieInstant> finishedCompactionInstants;
private final List<HoodieInstant> finishedOrRemovedLogCompactionInstants;
+ @Accessors(fluent = true)
Review Comment:
🤖 nit: mixing `@Accessors(fluent = true)` on just `canSyncIncrementally`
while the rest of `TimelineDiffResult` uses standard `getXxx()` getters gives
the class an inconsistent accessor API. Could you use
`@Getter(AccessLevel.NONE)` on this field and add the explicit
`canSyncIncrementally()` method back instead? That preserves the original API
without introducing two different accessor conventions on the same class.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
