wombatu-kun commented on code in PR #18805:
URL: https://github.com/apache/hudi/pull/18805#discussion_r3408876390
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java:
##########
@@ -156,8 +156,8 @@ public void addPropsFromFile(StoragePath filePath) {
);
try {
- if (filePath.equals(DEFAULT_PATH) && !storage.exists(filePath)) {
- log.debug("Properties file {} not found. Ignoring to load props file",
filePath);
+ if (!storage.exists(filePath)) {
+ log.warn("Properties file {} not found. Ignoring to load props file",
filePath);
Review Comment:
This promotes the log to warn for the DEFAULT_PATH branch as well.
hudi-defaults.conf is commonly absent, so loadGlobalProps (line 123) routes
DEFAULT_PATH through this same return and will now emit WARN on routine
global-props loads. #13986 deliberately downgraded this exact line from warn to
debug to cut that noise. Consider keeping debug when filePath equals
DEFAULT_PATH and warning only for explicitly user-specified files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
