voonhous opened a new pull request, #19002:
URL: https://github.com/apache/hudi/pull/19002
HoodieAppendHandle.close() called storage.getPathInfo(<logFile>).getLength()
for every WriteStatus to record the final log file size -- a remote HEAD per
log file per file group on object stores, purely to read a size the handle
already knows.
HoodieLogFormatWriter.appendBlocks reports, via AppendResult, the start
offset and the total bytes appended (covering every on-disk byte: magic,
header, content, footers, reverse-pointer long); these already populate the
delta write stat's logOffset and accumulated fileSizeInBytes. Appends within a
handle are contiguous and closeStream() appends no trailer, so a log file's
on-disk length equals logOffset + fileSizeInBytes. Set the final size from
those fields instead of issuing a getPathInfo/HEAD per file.
Byte-identical to getFileStatus().getLength(); same class of change as the
merged clean-path getPathInfo removal (#18963).
Closes #19001
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
