hudi-agent commented on code in PR #18957: URL: https://github.com/apache/hudi/pull/18957#discussion_r3409085030
########## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java: ########## @@ -53,6 +54,7 @@ import static org.apache.hudi.common.table.timeline.TimelineUtils.getInputStreamOptionLegacy; +@NoArgsConstructor Review Comment: 🤖 nit: this drops both the `@Deprecated` annotation and the "for serialization and de-serialization only" Javadoc that the old explicit constructor had. Could you mirror what `ActiveTimelineV1`/`V2` do here — i.e. `@NoArgsConstructor(onConstructor_ = @Deprecated)` plus a comment — so the intent stays visible? <sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> ########## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ActiveTimelineV1.java: ########## @@ -62,6 +62,9 @@ import static org.apache.hudi.common.table.timeline.TimelineUtils.getHoodieInstantWriterOption; +// no-arg constructor is for serialization and de-serialization only; @Deprecated marks it as such Review Comment: 🤖 nit: the `; @Deprecated marks it as such` half of this comment is redundant with the annotation itself — could you trim to just "no-arg constructor is for serialization/deserialization only" to keep the intent crisp? <sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
