voonhous commented on code in PR #19003:
URL: https://github.com/apache/hudi/pull/19003#discussion_r3411499023
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/clean/TestCleanerInsertAndCleanByVersions.java:
##########
@@ -133,6 +133,10 @@ private void testInsertAndCleanByVersions(
.withBulkInsertParallelism(PARALLELISM)
.withFinalizeWriteParallelism(PARALLELISM)
.withDeleteParallelism(PARALLELISM)
+ // #17714: enabling the consistency check makes this test slow on
macOS local file://. The cleaner's
+ // getFileStatus calls the guard's waitTillFileAppears, which misses
the translated path and burns the
+ // full ~25.2s backoff per deleted file. Does NOT reproduce on CI
(Linux), where the path resolves and
Review Comment:
Yeap we could! But it will have no effect on the test run times.
This PR serves as to document this "gotcha" while testing locally on MacOS
which i ran into months ago.
Adding this so no one else will go down the same rabbit hole i did.
If we want to turn off this feature, let's create a new issue task + PR
since this is a `chore` classed PR. and changing the config = changing
behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
