vinothchandar commented on a change in pull request #2494:
URL: https://github.com/apache/hudi/pull/2494#discussion_r594656644



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileReader.java
##########
@@ -232,12 +246,13 @@ public long getTotalRecords() {
   }
 
   @Override
-  public void close() {
+  public synchronized void close() {
     try {
       reader.close();
       reader = null;
+      keyScanner = null;
     } catch (IOException e) {
-      e.printStackTrace();

Review comment:
       @prashantwason fixed this as well. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to