suryaprasanna commented on PR #19023:
URL: https://github.com/apache/hudi/pull/19023#issuecomment-4736663494
> The problem can be reproduced by the following test case, can you add the
case in `TestWriteMergeOnRead`?
>
> ```
> @Test
> public void testCommittingMultipleInstantsWithOCC() throws Exception {
> // reset the config option
> conf.setString(HoodieWriteConfig.WRITE_CONCURRENCY_MODE.key(),
WriteConcurrencyMode.OPTIMISTIC_CONCURRENCY_CONTROL.name());
> preparePipeline(conf)
> .consume(TestData.DATA_SET_INSERT)
> .checkpoint(1)
> .assertNextEvent(4, "par1,par2,par3,par4")
> .consume(TestData.DATA_SET_UPDATE_INSERT)
> .checkpoint(2)
> .assertNextEvent(4, "par1,par2,par3,par4")
> .checkpointComplete(2)
> .checkWrittenData(EXPECTED2)
> .end();
> }
> ```
Added the test. While implementing it, discovered the same stale-baseline
issue in commitInstants() (L611) -- when checkpointComplete(2) commits both
checkpoints sequentially, the second sees the first as a concurrent conflict.
Fixed that path too. All 50 tests in TestWriteMergeOnRead pass including
existing multi-writer tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
