voonhous commented on code in PR #18938: URL: https://github.com/apache/hudi/pull/18938#discussion_r3434774312
########## hudi-common/src/main/java/org/apache/hudi/avro/VariantSchemaUtils.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.avro; + +import org.apache.hudi.common.schema.HoodieSchema; +import org.apache.hudi.common.schema.HoodieSchemaField; +import org.apache.hudi.common.schema.HoodieSchemaType; + +import java.util.ArrayList; +import java.util.List; + +/** + * Shared helpers for converting between shredded and unshredded variant schemas. + * Used by both the write path ({@link HoodieAvroWriteSupport}) and the read path + * (variant reconstruction in the parquet reader). + */ +public class VariantSchemaUtils { + + private VariantSchemaUtils() { Review Comment: Leaving this as-is. `org.apache.hudi.avro` isn't uniformly `Hoodie`-prefixed -- it has a direct `*SchemaUtils` sibling without the prefix, `AvroSchemaUtils`, plus `AvroSchemaCache`, `AvroRecordContext`, `AvroRecordSerializer`, `GenericAvroSerializer`, `MercifulJsonConverter`. `VariantSchemaUtils` follows the same feature-prefix style as `AvroSchemaUtils`, so it's consistent with the package as it stands; adding `Hoodie` would make it the odd one out next to `AvroSchemaUtils`. ########## hudi-common/src/main/java/org/apache/hudi/avro/VariantShreddingProvider.java: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.avro; + +import org.apache.hudi.common.schema.HoodieSchema; + +import org.apache.avro.Schema; +import org.apache.avro.generic.GenericRecord; + +/** + * Interface for shredding variant values at write time. + * <p> + * Implementations parse variant binary data (value + metadata bytes) and produce + * a shredded {@link GenericRecord} with typed_value columns populated according + * to the shredding schema. + * <p> + * This interface allows the variant binary parsing logic (which may depend on + * engine-specific libraries like Spark's variant module) to be loaded via reflection, + * keeping the core write support free of engine-specific dependencies. + */ +public interface VariantShreddingProvider { + + /** Review Comment: Same as the `VariantSchemaUtils` thread: `org.apache.hudi.avro` is a mixed package (`AvroSchemaUtils`, `AvroSchemaCache`, `AvroRecordContext`, `GenericAvroSerializer`, ... carry no `Hoodie` prefix), so `VariantShreddingProvider` is consistent with the existing `Avro*` feature-prefix style. It's also an existing interface from #18065 (this PR only extends it with `rebuildVariantRecord`), so renaming would churn the merged interface and all implementors/callers for no net consistency gain. Keeping as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
