yihua commented on code in PR #19062:
URL: https://github.com/apache/hudi/pull/19062#discussion_r3470664948
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java:
##########
@@ -175,6 +183,15 @@ public void setUpMORTestTable() throws IOException {
@AfterEach
public void clean() throws IOException {
+ if (currentTestingServer != null) {
+ try {
+ currentTestingServer.close();
+ } catch (Exception e) {
+ LOG.warn("Failed to close TestingServer in @AfterEach", e);
+ } finally {
+ currentTestingServer = null;
+ }
+ }
Review Comment:
We should drop `currentTestingServer` give the try-finally properly closes
the resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
