yihua commented on code in PR #18574:
URL: https://github.com/apache/hudi/pull/18574#discussion_r3502357461
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/ProtoConversionUtil.java:
##########
@@ -328,7 +329,9 @@ private Object getDefault(HoodieSchema fieldSchema,
Descriptors.FieldDescriptor
case SFIXED64:
return 0;
case UINT64:
- return DECIMAL_CONVERSION.toFixed(new BigDecimal(BigInteger.ZERO),
fieldSchema.toAvroSchema(),
fieldSchema.toAvroSchema().getLogicalType()).bytes();
+ return new String(
+ DECIMAL_CONVERSION.toFixed(new BigDecimal(BigInteger.ZERO),
fieldSchema.toAvroSchema(),
fieldSchema.toAvroSchema().getLogicalType()).bytes(),
+ StandardCharsets.ISO_8859_1);
Review Comment:
+1. Let's reuse `HoodieAvroUtils.convertDefaultValueForAvroCompatibility`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
