danny0405 commented on code in PR #19118:
URL: https://github.com/apache/hudi/pull/19118#discussion_r3505030208
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/util/CommonClientUtils.java:
##########
@@ -120,6 +130,23 @@ public static HoodieLogBlock.HoodieLogBlockType
getLogBlockType(HoodieWriteConfi
}
}
+ /**
+ * Whether log blocks should be written in the native (v2) log format
(standalone native
+ * files written via {@code HoodieNativeLogFormatWriter}) instead of the
legacy inline
+ * log format. The native format is the default for write version >=
{@link HoodieTableVersion#TEN}.
+ *
+ * <p>This decision is orthogonal to the storage layout (e.g. LSM-tree); it
is keyed on the
+ * effective write version (i.e. {@code
HoodieWriteConfig#getWriteVersion()}) and base file format
+ * rather than the persisted table version, consistent with how the inline
log block layout is
+ * selected, so that the on-disk format follows what the writer is targeting
during
+ * upgrade/downgrade windows.
+ *
+ * @param writeConfig the writer configuration.
+ */
+ public static boolean shouldWriteNativeLogFormat(HoodieWriteConfig
writeConfig) {
Review Comment:
rename to shouldWriteNativeLogs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
