danny0405 commented on code in PR #19118:
URL: https://github.com/apache/hudi/pull/19118#discussion_r3519497915
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -379,14 +379,21 @@ protected boolean writeRecord(HoodieRecord<T>
hoodieRecord) {
return true;
} catch (Exception e) {
log.error("Error writing record " + hoodieRecord, e);
- if (!config.getIgnoreWriteFailed()) {
+ if (!config.getIgnoreWriteFailed() || shouldFailOnWriteException(e)) {
throw new HoodieException(e.getMessage(), e);
}
writeStatus.markFailure(hoodieRecord, e, recordMetadata);
return false;
}
}
+ /**
+ * Returns whether a write exception should fail the task even when
record-level write failures are ignored.
+ */
+ protected boolean shouldFailOnWriteException(Exception e) {
+ return false;
Review Comment:
the inline log writer should also throw the
HoodieEarlyConflictDetectionException out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
