yihua opened a new pull request, #19218:
URL: https://github.com/apache/hudi/pull/19218

   ### Describe the issue this Pull Request addresses
   
   The Hudi-specific surface of the extended SQL parser has thin unit coverage. 
This adds a focused ScalaTest suite for the parts that are Hudi-owned and 
survive across Spark versions: the index DDL commands (CREATE / DROP / SHOW / 
REFRESH INDEX) and the Hudi column types (BLOB, VECTOR). This is test-only and 
adds no production code.
   
   ### Summary and Changelog
   
   Adds `TestExtendedSqlParserCoverage` under 
`hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/command/index/`,
 which already runs on every Spark version leg. The suite is intentionally 
scoped to the Hudi-specific parser surface only; it does not touch general 
query/DML parsing and does not add time-travel tests (those are already covered 
by `TestTimeTravelTable`).
   
   - Index DDL is asserted on the parsed logical plan directly 
(`spark.sessionState.sqlParser.parsePlan`), since `CreateIndex`, `DropIndex`, 
`HoodieShowIndexes`, and `RefreshIndex` are Hudi-owned plan classes that are 
stable across Spark versions. Each test asserts the plan class plus the index 
name and target table.
   - Column types (BLOB, VECTOR) are asserted through the catalog schema 
(`catalog.getTableMetadata(TableIdentifier(t)).schema`) rather than on 
`CreateTable` plan fields, because those fields differ between Spark 3.5 
(`tableSchema: StructType`) and 4.x (`columns: Seq[ColumnDefinition]`). The 
catalog schema check stays version-agnostic.
   
   No code was copied.
   
   ### Impact
   
   None. Test-only change; no public API or user-facing behavior change.
   
   ### Risk Level
   
   low
   
   Test-only addition. The suite avoids matching on version-specific plan 
fields and only asserts on Hudi-owned plan classes and the version-agnostic 
catalog schema, so it passes across the supported Spark versions.
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to