cshuo commented on code in PR #18372: URL: https://github.com/apache/hudi/pull/18372#discussion_r3542062804
########## hudi-common/src/main/java/org/apache/hudi/metadata/model/FileInfoAndPartition.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.metadata.model; + +import lombok.Getter; +import lombok.experimental.Accessors; + +/** + * Immutable descriptor for a file that should be scanned during index bootstrap. + */ +@Getter +@Accessors(fluent = true) +public class FileInfoAndPartition { + private final String partitionPath; + private final String name; + private final long size; Review Comment: Fixed. ########## hudi-common/src/main/java/org/apache/hudi/metadata/MetadataPartitionType.java: ########## @@ -453,8 +454,25 @@ public static Set<String> getAllPartitionPaths() { */ public static MetadataPartitionType[] getValidValues() { Review Comment: Fixed. ########## hudi-common/src/main/java/org/apache/hudi/metadata/model/FileSliceAndPartition.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.metadata.model; + +import org.apache.hudi.common.model.FileSlice; + +import lombok.AllArgsConstructor; +import lombok.ToString; +import lombok.Getter; +import lombok.Setter; +import lombok.experimental.Accessors; + +/** + * Holder for a {@link FileSlice} and its partition path. + */ +@AllArgsConstructor +@Getter +@Setter +@ToString +@Accessors(fluent = true) +public class FileSliceAndPartition { Review Comment: Fixed. ########## hudi-common/src/main/java/org/apache/hudi/metadata/model/FileSliceAndPartition.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.metadata.model; + +import org.apache.hudi.common.model.FileSlice; + +import lombok.AllArgsConstructor; +import lombok.ToString; +import lombok.Getter; +import lombok.Setter; +import lombok.experimental.Accessors; + +/** + * Holder for a {@link FileSlice} and its partition path. + */ +@AllArgsConstructor +@Getter +@Setter +@ToString Review Comment: Fixed. ########## hudi-common/src/main/java/org/apache/hudi/metadata/model/FileSliceAndPartition.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.metadata.model; + +import org.apache.hudi.common.model.FileSlice; + +import lombok.AllArgsConstructor; +import lombok.ToString; +import lombok.Getter; +import lombok.Setter; +import lombok.experimental.Accessors; + +/** + * Holder for a {@link FileSlice} and its partition path. + */ +@AllArgsConstructor +@Getter +@Setter +@ToString +@Accessors(fluent = true) +public class FileSliceAndPartition { + private FileSlice fileSlice; + private String partitionPath; + + public static FileSliceAndPartition of(String partitionPath, FileSlice fileSlice) { + return new FileSliceAndPartition(fileSlice, partitionPath); Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
