Joy-2000 commented on PR #19237: URL: https://github.com/apache/hudi/pull/19237#issuecomment-4927540742
> I think the explicit close of heartbeat should be fine since the default instant timeout gap for an instant is 10 minutes now which is enough to trigger a recommit. The 10-minute heartbeat timeout assumes the heartbeat file still exists. In our case, there's a window with no heartbeat file: after a failure stops the heartbeat, and before recommit to restart it. If an async clean job happens to run during this gap, a rollback becomes unavoidable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
