danny0405 commented on code in PR #19226:
URL: https://github.com/apache/hudi/pull/19226#discussion_r3556701259
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/ListingBasedRollbackStrategy.java:
##########
@@ -199,7 +211,8 @@ public List<HoodieRollbackRequest>
getRollbackRequests(HoodieInstant instantToRo
// (B.3) Rollback triggered for first commit - Same as (B.1)
// (B.4) Rollback triggered for recurring commits - Same as
(B.2) plus we need to delete the log files
// as well if the base file gets deleted.
- HoodieCommitMetadata commitMetadata =
commitMetadataOptional.get();
+ HoodieCommitMetadata commitMetadata =
+
metaClient.getActiveTimeline().readCommitMetadata(instantToRollback);
Review Comment:
is this a bug fix since the commitMetadataOptional might be empty even in
the old path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
