hudi-agent commented on code in PR #19275:
URL: https://github.com/apache/hudi/pull/19275#discussion_r3567998405
##########
pom.xml:
##########
@@ -693,7 +693,9 @@
<!-- local files not in version control -->
<exclude>**/*.iml</exclude>
<exclude>.mvn/**</exclude>
- <exclude>hudi-trino-plugin/**</exclude>
+ <!-- Match at any depth: the source-release checks copy the tree
into a scratch
+ directory, and a root-anchored pattern would not exclude
the copy. -->
+ <exclude>**/hudi-trino-plugin/**</exclude>
Review Comment:
🤖 Broadening `hudi-trino-plugin/**` to `**/hudi-trino-plugin/**` fixes the
scratch-copy case, but it also permanently excludes a `hudi-trino-plugin`
directory at *any* depth from RAT going forward. Since the real problem is the
copied tree, would excluding the scratch directory directly (e.g.
`hudi-tmp-repo/**`) be a more targeted fix that keeps RAT coverage tighter for
the real source tree? Curious whether you considered that alternative.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
