voonhous commented on code in PR #19265:
URL: https://github.com/apache/hudi/pull/19265#discussion_r3578057387


##########
hudi-lakehouse/charts/hudi-trino/templates/_helpers.tpl:
##########
@@ -0,0 +1,52 @@
+{{- /*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0

Review Comment:
   @vinothchandar Just a high level question over here. We're scoping the 
helm-charts here to be specific to agentic lakehouse deployment only? i.e. only 
for an embedded single-pod Trino inside the agentic-lakehouse stack.
   
   Are we considering the case for: user-facing at production scale 
(multi-worker, auth/TLS, pullable stock images, upstream-maintained topology)?
   
   I'm currently working on the Trino shim and will take reference from this. 
This will require some modification after RFC-105 is merged. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to