wombatu-kun commented on code in PR #19202:
URL: https://github.com/apache/hudi/pull/19202#discussion_r3592374741
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/cdc/CdcIterators.java:
##########
@@ -101,6 +101,11 @@ private CdcIterators() {
/**
* Iterates over an ordered sequence of {@link HoodieCDCFileSplit}s,
delegating
* per-split record reading to a user-supplied factory function.
+ *
+ * <p>Not thread-safe by design: in the Source V2 read path this iterator is
created, drained into a
+ * materialized minibatch, and closed entirely on the single split-fetcher
thread (see
Review Comment:
Agreed. In the Source V2 path the iterator is created, drained into the
minibatch, and closed only on the split-fetcher thread, so the first revision's
synchronization is dropped here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
