yihua commented on PR #19138: URL: https://github.com/apache/hudi/pull/19138#issuecomment-5042821043
Thanks for the thorough pass. Addressed the blocking and stale items in 2da96e2: - 🚨 Reverted the temporary DNM comment in `Base64CodecUtil.java`, so the diff is now config + docs only with zero coverable-line changes. Also dropped `[DNM]` from the title. - ⚠️ `MercifulJsonConverter`: dropped the entry (rather than repointing it) so it counts, since the reorg moved it under `common.avro` and it now has `TestMercifulJsonConverter`. Updated the neighboring comment and the PR description's "still-resolving" note accordingly. - 💬 `hudi-trino-plugin`: documented the deliberate omission with a comment in the `ignore` preamble, noting that modules whose CI jobs do not upload a report (its `test-hudi-trino-plugin` job) never reach Codecov, so they are intentionally absent from both `ignore` and `component_management`. - 💅 Nits: removed the redundant `-Djacoco.skip=false` from the README example (confirmed the root pom binds no `jacoco.skip` and the agent runs by default under `-Punit-tests`) and added the trailing newline. On the flag list: thanks for independently confirming against current master; agreed, no change. On `notify.wait_for_ci` + path-filtered jobs: good catch that this PR doesn't exercise that path since it touches `hudi-common`. I'll validate separately with a docs-only or flink-only throwaway PR that the comment still posts promptly when several flags never upload, and flip to `wait_for_ci: false` if it stalls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
