voonhous commented on code in PR #18837:
URL: https://github.com/apache/hudi/pull/18837#discussion_r3629333742
##########
pom.xml:
##########
@@ -87,7 +86,7 @@
<maven-surefire-plugin.version>3.5.4</maven-surefire-plugin.version>
<maven-failsafe-plugin.version>3.5.4</maven-failsafe-plugin.version>
<!-- bump to 3.5.3 to fix MSHADE-461 -->
- <maven-shade-plugin.version>3.5.3</maven-shade-plugin.version>
+ <maven-shade-plugin.version>3.6.2</maven-shade-plugin.version>
Review Comment:
Reverted to `3.5.3`. The bump was a leftover from when this branch still
carried the legacy `packaging/hudi-trino-bundle` (deleted in the migration
commit); `hudi-trino` is non-shaded, so nothing in this PR needs it.
##########
hudi-trino/README.md:
##########
@@ -0,0 +1,40 @@
+# hudi-trino
+
+Hudi connector for Trino (RFC-105). Published as `org.apache.hudi:hudi-trino`
-- a regular non-shaded JAR. The Trino-side `trino-hudi` plugin module depends
on this artifact and Trino's URLClassLoader isolates the plugin's transitive
deps from the rest of the server, so no shading is required.
+
+## Build
+
+Excluded from default builds. Activate the `hudi-trino` Maven profile:
+
+```
+# tests need Trino test-jars not on Maven Central (see Running tests); skip
them in the default build
+mvn -Phudi-trino -pl hudi-trino install -Dmaven.test.skip=true
+```
+
+Requires JDK 25 (enforced via `maven-enforcer-plugin`).
+
+## Running tests
+
+Tests depend on Trino test-jars (`trino-spi`, `trino-filesystem`,
`trino-hive`, `trino-main` at the `tests` classifier). Trino does not publish
three of those to Maven Central, so the test deps live behind the
`hudi-trino-tests` profile, off by default.
+
+To run the tests:
+
+1. Build the matching Trino version locally so its `*-tests.jar` artifacts
land in your `~/.m2` (see `trino.version` in the root pom for the version to
build).
+2. Activate both profiles:
+
+```
+mvn -Phudi-trino,hudi-trino-tests -pl hudi-trino test
+```
+
+CI keeps `hudi-trino-tests` off so the build resolves cleanly against Maven
Central.
Review Comment:
Updated: the line now says CI installs the test-jars from a source checkout
of the pinned Trino tag and runs with both profiles enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
