nsivabalan commented on code in PR #19342:
URL: https://github.com/apache/hudi/pull/19342#discussion_r3631199210
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/CustomAvroKeyGenerator.java:
##########
@@ -161,7 +162,7 @@ public String getPartitionPath(GenericRecord record) {
partitionPath.append(DEFAULT_PARTITION_PATH_SEPARATOR);
}
}
- return partitionPath.toString();
+ return
PartitionPathEncodeUtils.validateNoPathTraversal(partitionPath.toString());
Review Comment:
yeah. I was also thinking about the same.
but why specific to hoodie.datasource.write.partitionpath.urlencode=true
case.
alternatively, we could move this validation to write handles where we try
to create the partition meta file. and throw exception that we may not support
this. this is 1 validation per write handle, much lighter than above solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
