voonhous commented on code in PR #18492:
URL: https://github.com/apache/hudi/pull/18492#discussion_r3652192962
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/StorageBasedLockProvider.java:
##########
@@ -631,19 +551,13 @@ protected synchronized boolean renewLock() {
hoodieLockMetrics.ifPresent(HoodieLockMetrics::updateLockStateUnknownMetric);
// Let heartbeat retry later.
return true;
- case THROTTLED:
- // Throttling is transient, let the heartbeat retry on its next
cycle.
- logger.warn("Owner {}: Unable to renew lock due to throttling, will
retry on next heartbeat.", ownerId);
-
hoodieLockMetrics.ifPresent(HoodieLockMetrics::updateLockThrottledMetric);
- // Let heartbeat retry later.
- return true;
case SUCCESS:
// Only positive outcome
this.setLock(currentLock.getRight().get());
hoodieLockMetrics.ifPresent(metrics ->
metrics.updateLockExpirationDeadlineMetric(
- (int) (oldExpirationMs - getCurrentEpochMs())));
- logger.info("Owner {}: Lock renewal successful. The renewal
completes {} ms before expiration for lock {}.",
- ownerId, oldExpirationMs - getCurrentEpochMs(), lockFilePath);
+ (int) (lockExpirationMs - getCurrentEpochMs())));
Review Comment:
Done. Resolviong it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
