codope commented on code in PR #18988:
URL: https://github.com/apache/hudi/pull/18988#discussion_r3663278211
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -287,7 +283,7 @@ public boolean commitStats(String instantTime,
TableWriteStats tableWriteStats,
boolean postCommitStatus = true;
HoodieTimer postCommitTimer = HoodieTimer.start();
try {
- postCommit(table, metadata, instantTime, extraMetadata);
+ postCommit(table, metadata, instantTime, commitActionType,
extraMetadata);
Review Comment:
Intentional, and now called out explicitly in the PR description. When
`postCommit` runs, the commit instant is already complete on the timeline, so
the callback signals that the data commit is durable;
`mayBeCleanAndArchive`/`runTableServicesInline` are post-commit maintenance and
their failure doesn't un-commit the data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
