hudi-agent commented on code in PR #19389:
URL: https://github.com/apache/hudi/pull/19389#discussion_r3663546609
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/common/table/read/TestHoodieFileGroupReaderOnSpark.scala:
##########
@@ -233,7 +233,8 @@ class TestHoodieFileGroupReaderOnSpark extends
TestHoodieFileGroupReaderBase[Int
def testCustomDelete(useFgReader: String,
tableType: String,
positionUsed: String,
- mergeMode: String): Unit = {
+ mergeMode: String,
+ markerFromTableConfigOnly: String): Unit = {
Review Comment:
🤖 nit: could you type this as `Boolean` instead of `String`? Passing
`"true"`/`"false"` literals through `Arguments.of` and then checking
`.equals("true")` inside the method is easy to misread — a `Boolean` parameter
makes the intent self-evident and removes the stringly-typed comparison.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
