hudi-agent commented on code in PR #19427:
URL: https://github.com/apache/hudi/pull/19427#discussion_r3686626271
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java:
##########
@@ -211,7 +211,16 @@ protected void doSync() {
syncHoodieTable(snapshotTableName, true, false);
// sync origin table for MOR
if (config.getBoolean(META_SYNC_SNAPSHOT_WITH_TABLE_NAME)) {
- syncHoodieTable(tableName, true, false);
+ if
(config.getBoolean(HIVE_SKIP_RO_SUFFIX_FOR_READ_OPTIMIZED_TABLE)) {
+ // skip_ro_suffix explicitly claims the bare table name for
the RO view;
+ // an implicit sync_snapshot_with_table_name default must not
repurpose it as RT.
+ log.warn("{}=true claims the base table name '{}' for the
read-optimized view; "
Review Comment:
🤖 nit: "base table name" could be confused with Hudi's base-file concept —
the test comments consistently use "bare table name" (meaning the unsuffixed
name), which is clearer here too.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
