hudi-agent commented on code in PR #19425:
URL: https://github.com/apache/hudi/pull/19425#discussion_r3687806913
##########
packaging/hudi-utilities-bundle/pom.xml:
##########
@@ -153,6 +153,43 @@
<include>com.101tec:zkclient</include>
<include>org.apache.kafka:kafka-clients</include>
+ <!-- AWS SDK v2 core, shared by the kinesis and sts clients
below; relocated further down. -->
+ <include>software.amazon.awssdk:annotations</include>
+ <include>software.amazon.awssdk:utils</include>
+ <include>software.amazon.awssdk:sdk-core</include>
+ <include>software.amazon.awssdk:aws-core</include>
+ <include>software.amazon.awssdk:auth</include>
+ <include>software.amazon.awssdk:http-client-spi</include>
+ <include>software.amazon.awssdk:regions</include>
+ <include>software.amazon.awssdk:metrics-spi</include>
+ <include>software.amazon.awssdk:json-utils</include>
+ <include>software.amazon.awssdk:endpoints-spi</include>
+ <include>software.amazon.awssdk:retries</include>
+ <include>software.amazon.awssdk:retries-spi</include>
+ <include>software.amazon.awssdk:checksums</include>
+ <include>software.amazon.awssdk:checksums-spi</include>
+ <include>software.amazon.awssdk:identity-spi</include>
+ <include>software.amazon.awssdk:http-auth</include>
+ <include>software.amazon.awssdk:http-auth-spi</include>
+ <include>software.amazon.awssdk:http-auth-aws</include>
+
<include>software.amazon.awssdk:http-auth-aws-eventstream</include>
+ <include>software.amazon.awssdk:protocol-core</include>
+ <include>software.amazon.awssdk:apache-client</include>
+ <include>software.amazon.awssdk:netty-nio-client</include>
+ <include>org.reactivestreams:reactive-streams</include>
+ <!-- Kinesis client for JsonKinesisSource -->
+ <include>software.amazon.awssdk:kinesis</include>
+ <include>software.amazon.awssdk:aws-cbor-protocol</include>
+ <include>software.amazon.awssdk:aws-json-protocol</include>
+
<include>software.amazon.awssdk:third-party-jackson-dataformat-cbor</include>
+
<include>software.amazon.awssdk:third-party-jackson-core</include>
+ <!-- STS: assume-role credentials for cross-account Kinesis
reads (KinesisOffsetGen). -->
+ <include>software.amazon.awssdk:sts</include>
+ <include>software.amazon.awssdk:aws-query-protocol</include>
+ <include>software.amazon.awssdk:profiles</include>
+ <!-- KPL de-aggregation: extracts user records from Kinesis
Producer Library aggregated records -->
+ <include>com.amazonaws:amazon-kinesis-deaggregator</include>
Review Comment:
🤖 The reworked list still only adds `amazon-kinesis-deaggregator`, not
`com.amazonaws:amazon-kinesis-client`. `KinesisDeaggregator` imports
`com.amazonaws.services.kinesis.clientlibrary.types.UserRecord`, which lives in
`amazon-kinesis-client` (not the deaggregator jar), so the standalone bundle
would still hit `NoClassDefFoundError` on `UserRecord`. `hudi-aws-bundle`
includes both — could you add
`<include>com.amazonaws:amazon-kinesis-client</include>` here to match?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
