voonhous commented on PR #19460: URL: https://github.com/apache/hudi/pull/19460#issuecomment-5162256757
Re the codecov patch-coverage gap: 2cbbd1321ccc adds `Test parse CREATE TABLE with BLOB column and invalid literal transform arguments`, covering seven more converted throw sites: - unsupported typed literal (`FOO 'bar'`) - hex literal `IllegalArgumentException` fallback (`X'zz'`) - both `Can only have a single from-to unit` arms - non-numeric unit value (`INTERVAL 'x' DAY`) - non-string from-to value (`INTERVAL 1 DAY TO HOUR`) - unsupported from-to pair (`INTERVAL '1' MONTH TO HOUR`) The remaining uncovered converted lines are intentionally left: - the `NumberFormatException`/`AnalysisException` re-wrap arms: their triggering exceptions changed type across Spark versions (e.g. an over-precision decimal literal now throws `SparkArithmeticException` on 4.x, bypassing the `AnalysisException` catch entirely), so no portable SQL reaches them on every profile - the bare-`INTERVAL` arm: grammar-unreachable through Hudi's pruned grammar (now commented in the builders) - `Invalid transform argument`: requires an ANTLR error-recovery tree, not producible from well-formed SQL text -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
