hudi-agent commented on code in PR #19474:
URL: https://github.com/apache/hudi/pull/19474#discussion_r3708883320
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/BaseHoodieCatalystExpressionUtils.scala:
##########
@@ -103,11 +137,7 @@ abstract class BaseHoodieCatalystExpressionUtils extends
HoodieCatalystExpressio
// Identity transformation
case attrRef: AttributeReference => Some(attrRef)
- // Date/time parsing expressions whose shapes are
Spark-version-specific
- case _ => unapplyOrderPreservingDateParsing(expr) match {
- case Some(child) => unapply(child)
- case None => None
- }
+ case _ => None
Review Comment:
🤖 Removing `unapplyOrderPreservingDateParsing` means raw
`ParseToDate`/`ParseToTimestamp` (analysis-time shapes) are no longer matched
here — `origin/master` did match them, and the earlier version of this PR
documented them as "still inspected by the expression-index and partition-stats
paths." I traced that the expression-index path unwraps `ParseTo*` via
`attributeFetcher` before the matcher sees it, and the read path sees
post-ReplaceExpressions shapes, so this looks safe to me. Could you confirm you
verified no path feeds a raw `ParseTo*` into
`translateIntoColumnStatsIndexFilterExpr` and thereby silently loses pruning
that worked on master?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
