codope commented on code in PR #19464:
URL: https://github.com/apache/hudi/pull/19464#discussion_r3709584509
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -644,7 +645,7 @@ private void completeClustering(HoodieReplaceCommitMetadata
replaceCommitMetadat
heartbeatClient.stop(clusteringCommitTime);
}
log.info("Clustering successfully on commit {} for table {}",
clusteringCommitTime, table.getConfig().getBasePath());
- fireCommitCallbackIfNecessary(clusteringCommitTime,
clusteringInstant.getAction(),
+ fireCommitCallbackIfNecessary(clusteringCommitTime,
completedClusteringInstant.getAction(),
Review Comment:
Agreed it's a marker, but the marker every other operation uses is the
*completed* action, not the operation kind:
- compaction fires
[COMMIT_ACTION](https://github.com/apache/hudi/blob/e4718be307900b5348f26bc113885f224c33896c/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java#L427)
even though its inflight is `compaction`
- log compaction fires
[DELTA_COMMIT_ACTION](https://github.com/apache/hudi/blob/e4718be307900b5348f26bc113885f224c33896c/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java#L501)
even though its inflight is `logcompaction`
- insert_overwrite / insert_overwrite_table / delete_partition reach the
callback through
`postCommit` with
[REPLACE_COMMIT_ACTION](https://github.com/apache/hudi/blob/e4718be307900b5348f26bc113885f224c33896c/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkInsertOverwriteCommitActionExecutor.java#L82)
- clustering on table version <= 6 already reports `replacecommit`, and did
so before HUDI-7905 split
the inflight action out
Hardcoding `CLUSTERING_ACTION` would make clustering the only operation
whose callback reports an
action with no completed instant behind it, and would silently change what a
version-8/9 table reports
relative to an older one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
