voonhous commented on code in PR #19478:
URL: https://github.com/apache/hudi/pull/19478#discussion_r3709746472
##########
hudi-trino/src/test/java/io/trino/plugin/hudi/split/TestHudiSplitFactory.java:
##########
@@ -192,6 +239,7 @@ private static FileSlice createFileSlice(DataSize
baseFileSize, Option<DataSize>
{
String fileId = "5a4f6a70-0306-40a8-952b-045b0d8ff0d4-0";
HoodieFileGroupId fileGroupId = new HoodieFileGroupId("partition",
fileId);
+ // Deliberately nonzero: split generation must ignore the reported
block size
Review Comment:
Good catch, you are right that those two did not pin anything. The fixture
block size now mirrors the base file length, which is what `convertToPathInfo`
reports after this change.
Verified by restoring `max(target_split_size, blockSize)` locally -- 5 tests
fail:
- `testCreateHudiSplitsWithFileLargerThanDefaultTarget` (500MB collapses to
1 split instead of 4)
- `testCreateHudiSplitsWithExactSplitDivide`
- `testCreateHudiSplitsWithSlightlyOversizedFile`
- `testCreateHudiSplitsWithOversizedFileExceedingSlop`
- `testCreateHudiSplitsIgnoresBlockSize`
`testCreateHudiSplitsWithFileSmallerThanDefaultTarget` still passes either
way -- that one is the upstream repro that has to hold regardless of the
`max()`, not a pin on its removal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
