hudi-agent commented on code in PR #19424: URL: https://github.com/apache/hudi/pull/19424#discussion_r3716151511
########## website/docs/s3_hoodie.md: ########## @@ -61,6 +61,8 @@ Alternatively, add the required configs in your core-site.xml from where Hudi ca </property> ``` +Because Hudi reads and writes through the Hadoop S3A connector, these same `fs.s3a.*` settings target Amazon S3 as well as other S3-compatible object stores such as Backblaze B2, Cloudflare R2, and MinIO. For a non-AWS provider, set `fs.s3a.endpoint` to that provider's endpoint (for example `https://your-s3-endpoint.example.com`) and keep `fs.s3a.path.style.access` set to `true` when the provider requires path-style addressing. Review Comment: 🤖 This is a helpful addition. One small clarity concern: the wording "keep `fs.s3a.path.style.access` set to `true`" implies the value is already `true` in the preceding `core-site.xml`/config block. Since that setting isn't among the AWS example configs above (and its S3A default is `false`), a reader targeting a non-AWS store would actually need to *add* it. Could we reword to something like "set `fs.s3a.path.style.access` to `true` when the provider requires path-style addressing" to avoid implying it's already present? <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
