hudi-agent commented on code in PR #19522:
URL: https://github.com/apache/hudi/pull/19522#discussion_r3718983684
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetSchemaConverter.java:
##########
@@ -447,4 +447,14 @@ public static int computeMinBytesForDecimalPrecision(int
precision) {
}
return numBytes;
}
Review Comment:
🤖 nit: `decimalFixedLen` reads ambiguously — it sounds like it only applies
to fixed-type decimals, but it actually resolves the byte length for *any*
decimal, preferring the Avro fixed size when present. Something like
`resolveDecimalByteLength` might communicate the fallback logic more clearly.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
